Closed kissiel closed 2 weeks ago
Attention: Patch coverage is 98.11321%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 43.50%. Comparing base (
646fe88
) to head (89ec219
). Report is 6 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm closing this as it doesn't solve the issue we had and this was solved another way by @p-gentili
Description
TL;DR: A more reliable way to do EDID cycling with Zapper.
When debugging the Zapperized jobs that tested the changes in resolutions of the connected monitor (as emulated with Zapper), I noticed that the regexes failed to detect the right port on which the Zapper was connected. I also discovered there's plenty of corner cases which would be very hard to cover with just a regex extraction. Thus, I wrote a fully fledged parser for
xrandr
's andgnome-randr
's output. Both parsers are used in the new function I'm proposing here to land incheckbox-support
where it would return the information about display modes available on given video output.This in turn, when plugged into the
edid_cycle
test script started yielding true results from the job.Resolved issues
Fixes: https://warthogs.atlassian.net/browse/ZAP-677 Fixes: https://warthogs.atlassian.net/browse/ZAP-678
Tests
I tested the code by running it on multiple devices running both X11 and Wayland. I also propose unit tests with the code.