search

canonical / checkbox

Checkbox
https://checkbox.readthedocs.io
GNU General Public License v3.0
30 stars 44 forks source link

Migrate pc-santiy to contrib (New) #1246

Closed xanthein closed 3 weeks ago

xanthein commented 1 month ago

Description

Migrate the pc-sanity provider containing PC SWE related tests from an external repository into the new contrib area in Checkbox monorepo.

Resolved issues

Fixes OEX86-283

Documentation

This PR is an attempt to migrate pc-sanity provider into the contrib/ directory. This PR contains:

  1. contrib/pc-sanity: the provider itself.
  2. Infra for building debian package.

Regarding 2, it mimics what deb-daily-builds.yml does, creating another workflow called deb-sanity-builds.yml and includes the following steps:

  1. On push to the contrib/pc-sanity, the workflow sync its contents to lp:~checkbox-dev/checkbox by re-using lp_request_import.py.
  2. Then it modifies the build recipe according to the latest commit by modified lp_update_recipe.pyscript. This also require adding a new recipe (e.g. checkbox-contrib-pc-sanity-edge) to lp:~checkbox-dev/checkbox.
  3. Finally it triggers launchpad build by re-using lp_build_monitor_recipe.py.

Modified lp_update_recipe.py in 2. filter contrib in recipe name to get build path under contrib/ folder. Further discussion may be needed.

Also see README.md inside the contrib/ directory for information about the provider itself.

Tests

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.38%. Comparing base (ba754d6) to head (5011728). Report is 28 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1246 +/- ## ========================================== + Coverage 43.37% 43.38% +0.01% ========================================== Files 357 357 Lines 38693 38689 -4 Branches 6561 6562 +1 ========================================== + Hits 16784 16787 +3 + Misses 21245 21238 -7 Partials 664 664 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1246/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [release-tools](https://app.codecov.io/gh/canonical/checkbox/pull/1246/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `74.51% <100.00%> (+0.18%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hook25 commented 3 weeks ago

I have signed the commits for you, for the next ones remember we enforce commit signing, refer to this section of the contrib guide if you need more informations: https://github.com/canonical/checkbox/blob/main/CONTRIBUTING.md#signed-commits-required