search

canonical / checkbox

Checkbox
https://checkbox.readthedocs.io
GNU General Public License v3.0
30 stars 47 forks source link

Add testptp for TGPIO testing (Infra) #1249

Closed LiaoU3 closed 4 days ago

LiaoU3 commented 4 months ago

Description

Add testptp for TGPIO testing #1239

Resolved issues

N/A

Documentation

N/A

Tests

N/A

LiaoU3 commented 3 months ago

So this is interesting, you initially vendorized the files from the intel project, but then you rolled back the commit and added the rule in the snapcraft.yaml. I've tested this, it snaps, it is fine but what about all the other platforms (we support source, debs and 4 other snaps beside 22)? Wi will never support tgpio on these platforms? Can you explain me why you decided to roll back the vendorization and add this as a part in the yaml instead?

You are right. My PR cannot fit other platforms. Do you have any idea how I could fix this? The reason why I rollback the commit is due to LP#2065260

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 45.87%. Comparing base (d3078dd) to head (c55e7d7). Report is 38 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1249 +/- ## ======================================= Coverage 45.87% 45.87% ======================================= Files 367 367 Lines 39156 39156 Branches 6622 6622 ======================================= Hits 17961 17961 Misses 20504 20504 Partials 691 691 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1249/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [provider-base](https://app.codecov.io/gh/canonical/checkbox/pull/1249/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `19.91% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.