canonical / checkbox

Checkbox
https://checkbox.readthedocs.io
GNU General Public License v3.0
30 stars 44 forks source link

Replace category == 'AUDIO' with has_audio_playback (bugfix) #1283

Closed Hook25 closed 1 week ago

Hook25 commented 2 weeks ago

Description

As suggested by this comment, this PR replaces the device.category == 'AUDIO' with the has_audio_playback manifest entry. This manifest entry was selected because it seems to be used to exactly the same purpose (say if a machine is able to reproduce audio via any mean).

Note: this works also because the category was used to skip/execute tests but not as a template-filter

Resolved issues

Fixes: CHECKBOX-1224 Fixes: https://github.com/canonical/checkbox/issues/971

Documentation

N/A

Tests

Bestide the statical analysis I've ran the tests on my device with no changes.

Marking this as draft while I test it on a device that was previously skipping the test.

For the reviewer: please double check I imported the manifest everywhere, I already did multiple times, but it is better safe than sorry!

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.10%. Comparing base (a3d982d) to head (4127964).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1283 +/- ## ======================================= Coverage 44.10% 44.10% ======================================= Files 358 358 Lines 38765 38765 Branches 6571 6571 ======================================= Hits 17096 17096 Misses 21006 21006 Partials 663 663 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1283/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [provider-base](https://app.codecov.io/gh/canonical/checkbox/pull/1283/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `18.56% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.