search

canonical / checkbox

Checkbox
https://checkbox.readthedocs.io
GNU General Public License v3.0
30 stars 47 forks source link

Replace plainbox references (Infra) #1285

Closed waveform80 closed 3 months ago

waveform80 commented 3 months ago

Description

Replaces references to plainbox with checkbox or, where sensible, simply removes them. This only affects files under docs/ but even then there are places where plainbox references remain, such as in category and job identifiers. However, I'm reasonably confident that all the changes proposed are within prose only.

There are some references I've simply removed, because they reference specific plainbox versions and attempting to map these to checkbox versions is difficult and probably pointless (as they'll apply to all checkbox versions in current usage). There are also some "other" fixups, like a couple of obvious typos, a corrected path, and some fixed links.

The changes are organized into separate commits with the trivial obvious stuff first (where I'm confident that replacement of plainbox with checkbox is all that's needed), and the later commits covering stuff I'm a little less sure about which should probably be double-checked.

Each commit has additional commentary in the commit message. Where long paragraphs have been changed, I've re-wrapped things. If this makes things too hard to review, I'm happy to separate the re-wrap into a separate commit or just avoid the re-wrap entirely (and to rebase or re-work generally).

Resolved issues

Fixes: #1278

Tests

Tested build with sphinx locally; changes look reasonable and well formatted.

Hook25 commented 3 months ago

/canonical/self-hosted-runners/run-workflows 9c8760f60ae5bff5f8ebeedc2facf24260f19138

waveform80 commented 3 months ago

Added a commit capitalizing all the references to Checkbox that I changed, and another that simply quotes "checkbox" where it's referencing the generic snap rather than the project specifically.

Hook25 commented 3 months ago

/canonical/self-hosted-runners/run-workflows 3cb4e459788c6d5cbe534f09cfa3b5f41dd624fb

Hook25 commented 3 months ago

In order to land this we need signed commits, can you please sign your commits?

https://github.com/canonical/checkbox/blob/main/CONTRIBUTING.md#pull-requests

waveform80 commented 3 months ago

Should all be signed now (and verified after realizing the GPG key in GitHub hadn't been updated with new emails in forever)

Hook25 commented 3 months ago

/canonical/self-hosted-runners/run-workflows fc197c3ce4ec5b9b7358ab9a5f259c94fe8f577f