Open seankingyang opened 1 week ago
Attention: Patch coverage is 91.57895%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 44.29%. Comparing base (
ea9db5f
) to head (ac16772
). Report is 28 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
providers/base/bin/wifi_client_test_netplan.py | 91.57% | 7 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Netplan serves as a network configuration abstraction renderer and was officially released in the 24.04 LTS version. Netplan functions as a configuration tool for back-end daemons managing network interfaces, such as NetworkManager or systemd-networkd. In essence, Netplan acts as a configuration tool for back-end daemons managing network interfaces, independent of specific technologies.
In this PR, modify the
wifi_client_test_netplan.py
script to make it support both networkd and NetworkManger.generate_test_config
to create the configuration with the specified renderer.wait_for_routable
to support both networkd and NetworkManager._get_nmcli_state
to retrieve the connection state for NetworkManager.check_routable_state
to determine the appropriate_get_{nmcli | networkctl}_state
based on the renderer parameter.perform_ping_test
to accommodate both networkd and NetworkManager. (Obtain the Gateway method)get_gateway
, which will select the appropriate_get_{networkctl | nmcli}_gateway
based on the renderer parameter._get_networkctl_gateway
extracted from the func: perform_ping_test to support this functionality._get_nmcli_gateway
to obtain the gateway IP address from NetworkManager.print_journal_entries
to cater to both network and NetworkManager scenarios.According to the above issue, it need to add the following action:
Resolved issues
1303 (Netplan missing the key-management: psk when wpa/wpa2)
Documentation
Tests
Run cmd on systemd-networkd machine 202405-34023
Run checkbox wireless test category on machine 202405-34023