codecov[bot]
commented
1 week ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 44.17%. Comparing base (
b29ac00) to head (cb0a671). Report is 2 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1302 +/- ## ========================================== + Coverage 44.16% 44.17% +0.01% ========================================== Files 359 359 Lines 38812 38812 Branches 6581 6581 ========================================== + Hits 17141 17147 +6 + Misses 21007 21003 -4 + Partials 664 662 -2 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1302/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [checkbox-ng](https://app.codecov.io/gh/canonical/checkbox/pull/1302/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `67.59% <100.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
If checkbox times out connecting to the agent, it prints an error but exists with return code 0. This is an issue because we can't rely on
$?in this situation (like our canary pipeline does) and it clearly a bug. This fixes said bug.Resolved issues
Fixes: CHECKBOX-1468
Documentation
N/A
Tests
This adds a test for the "new" situation