canonical / checkbox

Checkbox
https://checkbox.readthedocs.io
GNU General Public License v3.0
30 stars 44 forks source link

Automate DVD test (New) #1305

Closed eugene-yujinwu closed 6 days ago

eugene-yujinwu commented 1 week ago

This PR was used to automated the DVD test, which used to be a manual test. After the change, the manual tests will be removed from the manual test plan, and a DVD read test will be added to the automatic test plan. If the DUT with a DVD or Bluray device, before run the automatic test, a new manifest item "has_dvd_bluray_inserted" will be asked. If the has_dvd_bluray_inserted had been labeled as yes, and a DVD or bluray disc was insterted. The DVD/Bluray read test will be run in the Automatic test.

Please refter the https://warthogs.atlassian.net/browse/OEMQA-4085 for more info and the test results.

Description

Resolved issues

Documentation

Tests

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.18%. Comparing base (8a9c908) to head (ffc896a). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1305 +/- ## ======================================= Coverage 44.17% 44.18% ======================================= Files 359 359 Lines 38812 38813 +1 Branches 6581 6581 ======================================= + Hits 17147 17148 +1 Misses 21003 21003 Partials 662 662 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1305/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [provider-base](https://app.codecov.io/gh/canonical/checkbox/pull/1305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `18.57% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hanhsuan commented 1 week ago

@eugene-yujinwu Do you know where the optical-cert-blockers and after-suspend-optical-cert-blockers are used?

eugene-yujinwu commented 1 week ago

@eugene-yujinwu Do you know where the optical-cert-blockers and after-suspend-optical-cert-blockers are used?

@hanhsuan sorry, I didn't get you. Have no idea about this.

hanhsuan commented 1 week ago

@eugene-yujinwu Do you know where the optical-cert-blockers and after-suspend-optical-cert-blockers are used?

@hanhsuan sorry, I didn't get you. Have no idea about this.

You modified these test plans, but I couldn't find where they are used.

eugene-yujinwu commented 1 week ago

@eugene-yujinwu Do you know where the optical-cert-blockers and after-suspend-optical-cert-blockers are used?

@hanhsuan sorry, I didn't get you. Have no idea about this.

You modified these test plans, but I couldn't find where they are used.

Hi @hanhsuan , they are used in the providers/certification-client/units/client-cert-desktop-22-04.pxu, or providers/certification-client/units/client-cert-desktop-24-04.pxu, such as https://github.com/canonical/checkbox/blob/dae49f57fe73c8535c2ecb32b85b9d277e12edaa/providers/certification-client/units/client-cert-desktop-22-04.pxu#L118 And client-cert-odm-desktop-22-04.pxu, client-cert-odm-desktop-24-04.pxu

hanhsuan commented 1 week ago

optical-cert-blockers

I mean optical-cert-blockers and after-suspend-optical-cert-blockers

image

eugene-yujinwu commented 1 week ago

optical-cert-blockers

I mean optical-cert-blockers and after-suspend-optical-cert-blockers

image

Ah, I got you. You mean these two test planes was not used by any other test plan. So we should just keep it unmodified, does it right?

hanhsuan commented 1 week ago

optical-cert-blockers

I mean optical-cert-blockers and after-suspend-optical-cert-blockers image

Ah, I got you. You mean these two test planes was not used by any other test plan. So we should just keep it unmodified, does it right?

Yes, you are right.

eugene-yujinwu commented 1 week ago

optical-cert-blockers

I mean optical-cert-blockers and after-suspend-optical-cert-blockers image

Ah, I got you. You mean these two test planes was not used by any other test plan. So we should just keep it unmodified, does it right?

Yes, you are right.

optical-cert-blockers

I mean optical-cert-blockers and after-suspend-optical-cert-blockers image

Ah, I got you. You mean these two test planes was not used by any other test plan. So we should just keep it unmodified, does it right?

Yes, you are right.

optical-cert-blockers

I mean optical-cert-blockers and after-suspend-optical-cert-blockers image

Ah, I got you. You mean these two test planes was not used by any other test plan. So we should just keep it unmodified, does it right?

Yes, you are right.

Thank you @hanhsuan , good catch. A new commit was pushed and the tests was added back.

eugene-yujinwu commented 5 days ago

Thank you @pieqq , glad you are back:)