canonical / checkbox

Checkbox
https://checkbox.readthedocs.io
GNU General Public License v3.0
30 stars 44 forks source link

netplan bugfix declare auth for non wpa3 (bugfix) #1306

Closed Hook25 closed 1 week ago

Hook25 commented 1 week ago

Description

This is a bugfix ported from #1301

The issue is that by not declaring the auth kind, the netbplan is not correctly parsed.

Resolved issues

Fixes: CHECKBOX-1471

Documentation

N/A

Tests

@p-gentili is testing this to see if it works in production, unit tests were updated

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.18%. Comparing base (8a9c908) to head (7b799ce).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1306 +/- ## ======================================= Coverage 44.17% 44.18% ======================================= Files 359 359 Lines 38812 38813 +1 Branches 6581 6581 ======================================= + Hits 17147 17148 +1 Misses 21003 21003 Partials 662 662 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1306/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [provider-base](https://app.codecov.io/gh/canonical/checkbox/pull/1306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `18.57% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.