search

canonical / checkbox

Checkbox
https://checkbox.readthedocs.io
GNU General Public License v3.0
30 stars 47 forks source link

Remove hdapsd packaging dependency from base provider (Bugfix) #1315

Closed pieqq closed 3 months ago

pieqq commented 3 months ago

Description

The HDD parking test requires HDAPSD (Hard Drive Active Protection System Daemon) to be installed on the system. However, this only makes sense on portable devices (laptops) using mechanical, rotational hard drives.

Nowadays, most laptops are shipped with SSD or NVMe drives that have no mechanical components.

By force-installing hdapsd, the associated service starts and immediately fails on devices without any mechanical hard drives. This is an issue for other tests, notably the poweroff and reboot tests, which both check for failed services. This has a big impact on automated test reviews in our lab.

This PR removes the packaging dependency. By doing so, the disk/hdd-parking job will be skipped by default since the hdapsd daemon won't be running. It can be manually installed on devices that require it to test it.

Resolved issues

Fix https://github.com/canonical/checkbox/issues/125

Documentation

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.18%. Comparing base (df0ef81) to head (f2934e9). Report is 114 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1315 +/- ## ======================================= Coverage 44.18% 44.18% ======================================= Files 359 359 Lines 38813 38813 Branches 6581 6581 ======================================= Hits 17148 17148 Misses 21003 21003 Partials 662 662 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1315/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [provider-certification-client](https://app.codecov.io/gh/canonical/checkbox/pull/1315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `57.14% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.