canonical / checkbox

Checkbox
https://checkbox.readthedocs.io
GNU General Public License v3.0
30 stars 47 forks source link

Add manifest entries for special key jobs (BugFix) #1387

Closed pieqq closed 4 weeks ago

pieqq commented 1 month ago

Description

Instead of relying on the generic has_special_keys manifest entry, create a manifest entry for each of the dedicated keys test present in Checkbox (for instance volume up/down, audio mute, microphone mute, video out, etc.)

Use this manifest entries in the related keys/* jobs.

Remove the unused has_special_keys manifest entry.

Delete mentions to "manually skip that test" for the keys/* jobs, since this is now controlled by a manifest entry.

This looks like this on my device when running the 24.04 desktop full test plan:

image

Resolved issues

https://warthogs.atlassian.net/browse/CHECKBOX-1321

Documentation

Tests

Tested locally on my DUT by running the 24.04 full test plan, and selecting the jobs in the Hotkey category. The section shown above appears in the System Manifest screen.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 45.12%. Comparing base (b3df727) to head (90ff66f). Report is 49 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1387 +/- ## ======================================= Coverage 45.12% 45.12% ======================================= Files 366 366 Lines 39058 39058 Branches 6607 6607 ======================================= Hits 17626 17626 Misses 20758 20758 Partials 674 674 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1387/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [provider-base](https://app.codecov.io/gh/canonical/checkbox/pull/1387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `18.62% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hanhsuan commented 1 month ago

There are more and more manifest. Is there an easy way to create manifest content for launcher without running the test plan?