Closed p-gentili closed 1 month ago
Attention: Patch coverage is 91.07143%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 45.18%. Comparing base (
7ab7c0f
) to head (8c08ee4
). Report is 6 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...box-support/checkbox_support/dbus/gnome_monitor.py | 76.92% | 2 Missing and 1 partial :warning: |
...heckbox-support/checkbox_support/monitor_config.py | 81.81% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Another PR dedicated to the EDID job. It turns out that the new implementation (https://github.com/canonical/checkbox/pull/1286) shed some light on the other related problem, where older machines could read the maximum allowed resolution.
In case where the HW doesn't support an available mode from the monitor EDID, no preferred mode is available (which makes sense). This PR takes care of such scenario, attempting to configure the monitor with the maximum available resolution.
Resolved issues
Resolves ZAP-678
Documentation
N/A
Tests
Tested on some machines.
Previous behaviour:
Running from source: