canonical / checkbox

Checkbox is a testing framework used to validate device compatibility with Ubuntu Linux. It’s the testing tool developed for the purposes of the Ubuntu Certification program.
https://checkbox.readthedocs.io
GNU General Public License v3.0
33 stars 50 forks source link

Handle HIDRAW devices that have no parents in the udev stack (BugFix) #1418

Closed jocave closed 3 months ago

jocave commented 3 months ago

Description

It appears when the code was written it expected HIDRAW devices to always appear in a tree of devices with at least one parent and so at least two items in the stack. It appears we are now encountering devices connected to machines which have no parents.

Link to original merge: https://github.com/canonical/checkbox/commit/fd54837c7374a480690ad7b3f395737fb6d70640

Resolved issues

Fixes #1407

Documentation

Tests

Included unit test additions from a machine where the bug was reported

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 45.18%. Comparing base (ff9f6b6) to head (5948e2c). Report is 118 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1418 +/- ## ======================================= Coverage 45.18% 45.18% ======================================= Files 366 366 Lines 39107 39107 Branches 6612 6612 ======================================= + Hits 17670 17671 +1 Misses 20764 20764 + Partials 673 672 -1 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1418/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [checkbox-support](https://app.codecov.io/gh/canonical/checkbox/pull/1418/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `59.71% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.