canonical / checkbox

Checkbox is a testing framework used to validate device compatibility with Ubuntu Linux. It’s the testing tool developed for the purposes of the Ubuntu Certification program.
https://checkbox.readthedocs.io
GNU General Public License v3.0
33 stars 50 forks source link

Handle no installed dkms modules (BugFix) #1426

Closed jocave closed 3 months ago

jocave commented 3 months ago

Description

The "testmain*" tests did not actually exercise anything because all calls where mocked and there wasnt any input provided.

The case where there was no dkms modules at all the system was not handled. Add a call_count on test main to ensure this addition wasnt skipping the apt log checking.

Resolved issues

Documentation

Tests

Additional unittests with input from more release

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 45.20%. Comparing base (7b00249) to head (9c7fb71). Report is 118 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1426 +/- ## ======================================= Coverage 45.20% 45.20% ======================================= Files 367 367 Lines 39125 39129 +4 Branches 6614 6615 +1 ======================================= + Hits 17688 17690 +2 - Misses 20764 20765 +1 - Partials 673 674 +1 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1426/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [provider-sru](https://app.codecov.io/gh/canonical/checkbox/pull/1426/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `97.97% <100.00%> (-2.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: