search

canonical / checkbox

Checkbox is a testing framework used to validate device compatibility with Ubuntu Linux. It’s the testing tool developed for the purposes of the Ubuntu Certification program.
https://checkbox.readthedocs.io
GNU General Public License v3.0
33 stars 50 forks source link

Update gadget interface validation test plan (BugFix) #1494

Closed stanley31huang closed 2 months ago

stanley31huang commented 2 months ago

update ce-oem-automated test plan and gadget interface test cases

Description

There are two major changes in this PR

  1. include the ce-oem-gadget-automated into the nested part of ce-oem-automated
  2. remove the also-after-suspend flag from the gadget interface tests.

    Documentation

    N/A

    Tests

    Passed the provider validation locally.

stanley31huang commented 2 months ago

Why don't we want to run the after suspend tests?

IIRC, the snap interfaces are initialized when the snap is installed, so we should be safe to ignore those tests in Post-suspend stage.

LiaoU3 commented 2 months ago

Why don't we want to run the after suspend tests?

IIRC, the snap interfaces are initialized when the snap is installed, so we should be safe to ignore those tests in Post-suspend stage.

I don't get it. What will happen if we test them after suspend?

stanley31huang commented 2 months ago

Why don't we want to run the after suspend tests?

IIRC, the snap interfaces are initialized when the snap is installed, so we should be safe to ignore those tests in Post-suspend stage.

I don't get it. What will happen if we test them after suspend?

I mean the snap interfaces are initialized when it is installed. Thus, the interface will not be affected during the suspend and resume process (unlike the kernel driver, which may experience changes or need reinitialization) . So we don't need to have the after-suspend tests.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.48%. Comparing base (104c931) to head (bc0a876). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1494 +/- ## ======================================= Coverage 47.48% 47.48% ======================================= Files 369 369 Lines 39586 39586 Branches 6685 6685 ======================================= Hits 18798 18798 Misses 20077 20077 Partials 711 711 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.