canonical / checkbox

Checkbox is a testing framework used to validate device compatibility with Ubuntu Linux. It’s the testing tool developed for the purposes of the Ubuntu Certification program.
https://checkbox.readthedocs.io
GNU General Public License v3.0
33 stars 50 forks source link

Switch from mobilebroadband to wwan nested parts for cert test plans (bugfix) #1496

Closed pieqq closed 1 month ago

pieqq commented 2 months ago

Description

Following QA changes in #821 regarding the replacement of mobilebroadband-cert-.* nested parts for their wwan-.* counterparts, the same is applied for:

client-cert-odm-desktop-18-04 was not included due to the fact that Ubuntu 18.04 has seen EOL and therefore its related test plan is not actively maintained anymore.

Resolved issues

Documentation

Tests

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.48%. Comparing base (104c931) to head (833eeab). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1496 +/- ## ======================================= Coverage 47.48% 47.48% ======================================= Files 369 369 Lines 39586 39586 Branches 6685 6685 ======================================= Hits 18798 18798 Misses 20077 20077 Partials 711 711 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1496/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [provider-base](https://app.codecov.io/gh/canonical/checkbox/pull/1496/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `24.02% <ø> (ø)` | | | [provider-certification-client](https://app.codecov.io/gh/canonical/checkbox/pull/1496/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `57.14% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pieqq commented 2 months ago

@jocave I noticed a lot of the after-suspend-.*-automated parts had been commented out in 42d8e0187961e4651bfdad2bbc0751f52543aaee, but I'm not sure why. This was done for 20.04 and then propagated to 22.04 and 24.04.

I still decided to include after-suspend-wwan-automated nested part is it is used in the client-desktop test plan, but I will need your feedback on this.

pieqq commented 1 month ago

Please see my inline comments.

Thanks, I messed up something when batch-editing the test plans!

The new pushed version should be better.

seankingyang commented 1 month ago

LGTM +1, thanks for the correction