search

canonical / checkbox

Checkbox is a testing framework used to validate device compatibility with Ubuntu Linux. It’s the testing tool developed for the purposes of the Ubuntu Certification program.
https://checkbox.readthedocs.io
GNU General Public License v3.0
33 stars 50 forks source link

Save submission url to file (bugfix) #1561

Closed Hook25 closed 4 weeks ago

Hook25 commented 4 weeks ago

Description

When submitting to C3, Checkbox receives a submission URL. This url is printed to the console. It is very hard and hackish to retreive this URL from the stdout of the process, therefore this adds a new rule to the exporter that also propagates this URL to a file on disk, printing the location like others do

Resolved issues

N/A

Documentation

N/A

Tests

This adds two new unit tests for the functionality + 1 for a small refactoring

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.00%. Comparing base (fc12ed5) to head (3b916a0). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
checkbox-ng/checkbox_ng/launcher/stages.py 95.83% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1561 +/- ## ========================================== + Coverage 47.88% 48.00% +0.12% ========================================== Files 371 371 Lines 39820 39833 +13 Branches 6731 6730 -1 ========================================== + Hits 19066 19121 +55 + Misses 20042 19994 -48 - Partials 712 718 +6 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1561/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [checkbox-ng](https://app.codecov.io/gh/canonical/checkbox/pull/1561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `68.60% <95.83%> (+0.31%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.