canonical / checkbox

Checkbox is a testing framework used to validate device compatibility with Ubuntu Linux. It’s the testing tool developed for the purposes of the Ubuntu Certification program.
https://checkbox.readthedocs.io
GNU General Public License v3.0
33 stars 49 forks source link

Mock os.makedirs in launcher return codes (bugfix) #1562

Closed Hook25 closed 3 weeks ago

Hook25 commented 3 weeks ago

Description

Test fails on launchpad because it doesn't mock the stage. Stage tries to save the C3 URL and crashes on PermissionDenied. Also, very bad idea to create the directory while running tests!

Resolved issues

N/A

Documentation

N/A

Tests

N/A

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.00%. Comparing base (8f4bd2b) to head (0a46173). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1562 +/- ## ======================================= Coverage 48.00% 48.00% ======================================= Files 371 371 Lines 39833 39833 Branches 6730 6730 ======================================= Hits 19121 19121 Misses 19994 19994 Partials 718 718 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1562/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [checkbox-ng](https://app.codecov.io/gh/canonical/checkbox/pull/1562/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `68.60% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.