canonical / checkbox

Checkbox is a testing framework used to validate device compatibility with Ubuntu Linux. It’s the testing tool developed for the purposes of the Ubuntu Certification program.
https://checkbox.readthedocs.io
GNU General Public License v3.0
33 stars 49 forks source link

Append to the submission log (bugfix) #1567

Closed Hook25 closed 3 weeks ago

Hook25 commented 3 weeks ago

Description

The submission url is part of more return values of just the C3 exporter. This was not intended intiially and makes it so the permanence on disk of the url depends on the order of exporters, which breaks the feature. Given this information though, this modifies the transport so that it appends to the log file and changes its name. This is a good idea because that way we can always to automatic manipulation of these files without having to wonder how they are called.

Namely, if a submission$NAME is created, to get the files that were generated as a part of that sumission one has to just consult the submission$NAME.submission.log file, which will contain all URIs, one per line. This is especially convenient if one happens to close the window after the submission is done.

This preserves the original intent to be able to recover the submission url from file without having to parse the checkbox-cli output.

Resolved issues

N/A

Documentation

N/A

Tests

The feature was already tested

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.00%. Comparing base (744a2af) to head (395458a). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1567 +/- ## ======================================= Coverage 48.00% 48.00% ======================================= Files 371 371 Lines 39833 39833 Branches 6730 6730 ======================================= Hits 19121 19121 Misses 19994 19994 Partials 718 718 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1567/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [checkbox-ng](https://app.codecov.io/gh/canonical/checkbox/pull/1567/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `68.60% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.