Open tomli380576 opened 1 week ago
Attention: Patch coverage is 93.75000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 48.00%. Comparing base (
76d8f30
) to head (81fe325
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
providers/base/bin/prime_offload_tester.py | 93.75% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This PR fixes the issue in the Resolved Issues section and replaced some type annotations with ones supported in python 3.5
Resolved issues
If
prime_offload_tester.py
was run with arguments likepython3 prime_offload_tester.py -d i915 -p 0000:00:02.0
and the command to check isglxgears
, the test always passes because it was checking if"glxgears"[0]
is one of the clients of this GPU. Since"glxgears"[0] == 'g'
, it always matches the g in "tgid" in/sys/kernel/debug/dri/<card_pci_id>/clients
.Now it will check if the entire string "glxgears" appears in the file
Documentation
Tests
Unit tests Ran the script on 202408-34290 with
-d i915 -p 0000:00:02.0
(Intel + NVIDIA desktop, expected to fail) and it correctly reports that prime offload didn't work