canonical / checkbox

Checkbox is a testing framework used to validate device compatibility with Ubuntu Linux. It’s the testing tool developed for the purposes of the Ubuntu Certification program.
https://checkbox.readthedocs.io
GNU General Public License v3.0
33 stars 49 forks source link

Executing a first run without ignoring the output on disk tests (Bugfix) #1592

Closed fernando79513 closed 1 week ago

fernando79513 commented 1 week ago

Description

I have created a quick fix to at show the whole output of hdparm the first run, because the test was always showing the Device $disk is too small! Aborting test. message if hdparm was failing for any reason.

Also making the test fail if no disk is selected as a parameter.

Resolved issues

N/A

Documentation

Tests

checkbox-cli run com.canonical.certification::disk-automated

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.03%. Comparing base (bdf6739) to head (eae27d5). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1592 +/- ## ======================================= Coverage 48.03% 48.03% ======================================= Files 371 371 Lines 39850 39850 Branches 6734 6734 ======================================= Hits 19140 19140 Misses 19993 19993 Partials 717 717 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1592/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [provider-base](https://app.codecov.io/gh/canonical/checkbox/pull/1592/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `24.71% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.