canonical / checkbox

Checkbox is a testing framework used to validate device compatibility with Ubuntu Linux. It’s the testing tool developed for the purposes of the Ubuntu Certification program.
https://checkbox.readthedocs.io
GNU General Public License v3.0
33 stars 49 forks source link

Add internal microphone manifest and update some audio jobs requirements (bugfix) #1594

Closed pieqq closed 1 week ago

pieqq commented 1 week ago

Description

Devices without an internal microphone should not run the audio/alsa_record_playback_internal job, as it requires one.

This issue was detected when reviewing test results to issue a certificate for a desktop PC. The audio/alsa_record_playback_internal job was marked as skipped, but it is a certification-blocker, so it triggered some alerts.

Resolved issues

The audio/alsa_record_playback_internal cert-blocker should have been skipped automatically in this submission, but because of the missing has_internal_microphone manifest, it was still executed even though it didn't make sense to, leading QA to have to manually skip the job.

Documentation

Tests

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.03%. Comparing base (27405cf) to head (10aa59d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1594 +/- ## ======================================= Coverage 48.03% 48.03% ======================================= Files 371 371 Lines 39850 39850 Branches 6734 6734 ======================================= Hits 19140 19140 Misses 19993 19993 Partials 717 717 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1594/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [provider-base](https://app.codecov.io/gh/canonical/checkbox/pull/1594/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `24.71% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.