canonical / checkbox

Checkbox is a testing framework used to validate device compatibility with Ubuntu Linux. It’s the testing tool developed for the purposes of the Ubuntu Certification program.
https://checkbox.readthedocs.io
GNU General Public License v3.0
33 stars 49 forks source link

Prevent mandatory jobs from being added to the list of rejected jobs (bugfix) #1602

Closed pieqq closed 2 days ago

pieqq commented 6 days ago

Description

When user de-selects jobs in the UI, they may de-select mandatory jobs. These jobs, even if de-selected, will still be added to the list of jobs to run later on, and will be executed.

Therefore, they should not be part of the rejected jobs list.

This problem does not happen when using the match feature.

Resolved issues

While investigating #1557 , I found this other issue.

Documentation

Tests

Apart from the unit test being updated, I ran the following test:

Launch Checkbox using this launcher:

[test plan]
unit = com.canonical.certification::client-cert-iot-ubuntucore-22-automated
forced = yes

De-select every job and run the test.

Check the generated submission.json:

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.03%. Comparing base (b965681) to head (2fcb7da). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1602 +/- ## ======================================= Coverage 48.03% 48.03% ======================================= Files 371 371 Lines 39852 39853 +1 Branches 6734 6735 +1 ======================================= + Hits 19142 19143 +1 Misses 19993 19993 Partials 717 717 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1602/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [checkbox-ng](https://app.codecov.io/gh/canonical/checkbox/pull/1602/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `68.65% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: