search

canonical / checkbox

Checkbox is a testing framework used to validate device compatibility with Ubuntu Linux. It’s the testing tool developed for the purposes of the Ubuntu Certification program.
https://checkbox.readthedocs.io
GNU General Public License v3.0
33 stars 49 forks source link

Move jobs to dedicated external provider (New) #1613

Open p-gentili opened 12 hours ago

p-gentili commented 12 hours ago

WARNING: This modifies com.canonical.certification::sru

Description

This is probably Breaking instead of New, but I don't think it's necessary to bump that major version. Your call.

This PR gets rid of every Zapper-driven job, moving to a dedicated external provider.

Also, a bit of refactor to the storage_watcher class was required, happy to change direction if that doesn't work for you.

Resolved issues

Part of ZAP-1002

Documentation

N/A

Tests

Only the storage watcher test case is impacted by this PR. It's a manual test.

codecov[bot] commented 12 hours ago

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.70%. Comparing base (fc12ed5) to head (6a1a45e). Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
providers/base/bin/removable_storage_watcher.py 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1613 +/- ## ========================================== - Coverage 47.88% 47.70% -0.18% ========================================== Files 371 367 -4 Lines 39820 39537 -283 Branches 6731 6698 -33 ========================================== - Hits 19066 18863 -203 + Misses 20042 19966 -76 + Partials 712 708 -4 ``` | [Flag](https://app.codecov.io/gh/canonical/checkbox/pull/1613/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | Coverage Δ | | |---|---|---| | [checkbox-support](https://app.codecov.io/gh/canonical/checkbox/pull/1613/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `60.35% <100.00%> (-0.37%)` | :arrow_down: | | [provider-base](https://app.codecov.io/gh/canonical/checkbox/pull/1613/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `24.06% <0.00%> (-0.66%)` | :arrow_down: | | [provider-certification-client](https://app.codecov.io/gh/canonical/checkbox/pull/1613/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `57.14% <ø> (ø)` | | | [provider-resource](https://app.codecov.io/gh/canonical/checkbox/pull/1613/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `34.99% <ø> (+0.70%)` | :arrow_up: | | [provider-sru](https://app.codecov.io/gh/canonical/checkbox/pull/1613/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical) | `97.97% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canonical#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: