search

canonical / chisel-releases

36 stars 51 forks source link

feat(24.04): add iptables, sudo and add mutation script for pam-auth-update #306

Open Meulengracht opened 3 months ago

Meulengracht commented 3 months ago

Proposed changes

Iptables is something we include in Ubuntu Core. Unfortunately to test iptables I need both sudo (which I then figured wasn't working due to bad libpam support), which resulted in a large mutation script that emulates what pam-auth-update does.

There are dedicated integration tests for the libpam generation and sudo, and the test for iptables currently is pretty shallow since it needs kernel modules loaded that aren't available.

Checklist

github-actions[bot] commented 3 months ago

Diff of dependencies:

slices/libpam-runtime.yaml ```diff @@ -1,4 +0,0 @@ -cdebconf -debconf -debconf-2.0 -libpam-modules ```
cjdcordeiro commented 3 months ago

@Meulengracht following up on this - it'd be nice to try these tests with LXD as well, once we get sort out why you're having those issues in #318

Meulengracht commented 3 months ago

@Meulengracht following up on this - it'd be nice to try these tests with LXD as well, once we get sort out why you're having those issues in #318

It passes on the LXD backend locally, I removed the caps and restored the tests

Meulengracht commented 3 months ago

@cjdcordeiro @rebornplusplus this is ready for review