canonical / chisel-releases

37 stars 51 forks source link

Please split common converters slice from libc6 gconv slice #368

Open vpa1977 opened 3 weeks ago

vpa1977 commented 3 weeks ago

libc6 slice definition splits package into libraries and gconv files.

Fedora implemented proposal[1] to move gconv files into a separate package except most commonly used converters UTF-*, unicode, ISO-8859-1, ISO8859-15, CP1252 and ANSI_X3.110..

Would it be possible to consider splitting gconv slice to have common converters installable?

Note: corresponding Debian bug[2]

[1] https://www.fedoraproject.org/wiki/Changes/Gconv_package_split_in_glibc [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1005193

rebornplusplus commented 3 weeks ago

Hello @vpa1977! Are you looking for something like below?

diff --git a/slices/libc6.yaml b/slices/libc6.yaml
index 3ea1e51..21ba10a 100644
--- a/slices/libc6.yaml
+++ b/slices/libc6.yaml
@@ -40,9 +40,20 @@ slices:
       /usr/lib/*-linux-*/libutil.so.*:

   gconv:
+    essential:
+      - libc6_gconv-core
     contents:
       /usr/lib/*-linux-*/gconv/**:

+  gconv-core:
+    contents:
+      /usr/lib/*-linux-*/gconv/ANSI_X3.110.so:
+      /usr/lib/*-linux-*/gconv/CP1252.so:
+      /usr/lib/*-linux-*/gconv/ISO8859-1.so:
+      /usr/lib/*-linux-*/gconv/ISO8859-15.so:
+      /usr/lib/*-linux-*/gconv/UNICODE.so:
+      /usr/lib/*-linux-*/gconv/UTF-*.so:
+
   copyright:
     contents:
       /usr/share/doc/libc6/copyright:

It works too:

$ chisel cut --release ./ --root out/ libc6_gconv-core
...
$ tree out/
out/
└── usr
    ├── lib
    │   └── x86_64-linux-gnu
    │       └── gconv
    │           ├── ANSI_X3.110.so
    │           ├── CP1252.so
    │           ├── ISO8859-15.so
    │           ├── ISO8859-1.so
    │           ├── UNICODE.so
    │           ├── UTF-16.so
    │           ├── UTF-32.so
    │           └── UTF-7.so
    └── share
        └── doc
            └── libc6
                └── copyright
vpa1977 commented 3 weeks ago

@rebornplusplus yes, this is perfect, thank you!!!!

rebornplusplus commented 3 weeks ago

Ah okay, please feel free to raise a PR. Just so you know, paths do not conflict within the same package or same slice.