search

canonical / chisel

GNU Affero General Public License v3.0
248 stars 39 forks source link

Support package names shorter than 3 characters #119

Closed rebornplusplus closed 4 months ago

rebornplusplus commented 5 months ago

Chisel does not currently support package names shorter than 3 characters. This is controlled by a few regular expressions specified in the setup package.

https://github.com/canonical/chisel/blob/11a324ceca40c373ae5298ff6b93986340a945d7/internal/setup/setup.go#L245-L247

However, this means that packages like jq are not currently supported. Per the debian policy, the minimum length of a package's name can be 2.

Package names (both source and binary, see Package) must consist only of lower case letters (a-z), digits (0-9), plus (+) and minus (-) signs, and periods (.). They must be at least two characters long and must start with an alphanumeric character.

Related: https://github.com/canonical/chisel-releases/pull/116

cjdcordeiro commented 5 months ago

unless you see an obvious rationale for keeping that limitation, I'd propose simply putting a PR up for adjusting that limit (unless it's not straightforward)

rebornplusplus commented 5 months ago

Yeah, this should be a very easy fix. I will add a PR for it shortly. I wanted to add the "Good first issue" label to this issue in case anyone wanted to try it out, but I can't. :confused: