search

canonical / cloud-init

Official upstream for the cloud-init: cloud instance initialization
https://cloud-init.io/
Other
2.99k stars 883 forks source link

initramfs network configuration ignored if only ip6= on kernel command line #2756

Closed ubuntu-server-builder closed 1 year ago

ubuntu-server-builder commented 1 year ago

This bug was originally filed in Launchpad as LP: #1639930

Launchpad details 
affected_projects = ['maas', 'cloud-init (Ubuntu)', 'cloud-init (Ubuntu Xenial)', 'cloud-init (Ubuntu Yakkety)']
assignee = None
assignee_name = None
date_closed = 2016-12-23T17:35:59.965261+00:00
date_created = 2016-11-07T20:14:10.057060+00:00
date_fix_committed = 2016-12-12T01:53:42.871510+00:00
date_fix_released = 2016-12-23T17:35:59.965261+00:00
id = 1639930
importance = medium
is_complete = True
lp_url = https://bugs.launchpad.net/cloud-init/+bug/1639930
milestone = None
owner = smoser
owner_name = Scott Moser
private = False
status = fix_released
submitter = smoser
submitter_name = Scott Moser
tags = ['maas-ipv6', 'verification-done']
duplicates = []

Launchpad user Scott Moser(smoser) wrote on 2016-11-07T20:14:10.057060+00:00

=== Begin SRU Template === [Impact] On a system booted with both ip6= and ip= on the kernel command line cloud-init will raise an exception and fail to process user-data and have its normal affect on boot.

That is because cloud-init previously raised an exception when more than one file in /run/net*.conf declared the same DEVICE. Changes to isc-dhcp and initramfs-tools have changed their behavior and cloud-init has to adjust to allow DEVICE6= and DEVICE= in separate files.

[Test Case] Boot a system on a network with both ipv4 and ipv6 dhcp servers, and pass kernel command line with:   ip=dhcp ip6=dhcp

[Regression Potential] Regression seems unlikely as this is relaxing a check. Where previously an exception would have been raised, cloud-init will now go on.

So it seems most likely, something that didn't work before (due to raised exception) would now still not work, but with failures. That is not expected, but that would likely be where regressions were found.

=== End SRU Template ===

In changes made under bug 1621615 (specifically a1cdebdea), we now expect that there may be a 'ip6=' argument on the kernel command line. The changes made did not test the case where there is 'ip6=' and no 'ip='.

The code currently will return with no network configuration found if there is only ip6=...

Related bugs:   bug 1621615: network not configured when ipv6 netbooted into cloud-init   bug 1621507: initramfs-tools configure_networking() fails to dhcp IPv6 addresses  * bug 1635716: Can't bring up a machine on a dual network (ipv4 and ipv6)

ubuntu-server-builder commented 1 year ago

Launchpad user Scott Moser(smoser) wrote on 2016-11-07T20:16:22.700112+00:00

The initial fix is easy, but bug 1621615 changes sneaked in without a unit test.

I'd really like a unit test of read_kernel_cmdline_config to accompany this change. Also, a change to 'DHCP6_CONTENT_1' in tests/unittests/test_net.py to contain what we're currently expecting.

diff --git a/cloudinit/net/cmdline.py b/cloudinit/net/cmdline.py index 4075a27..a077730 100644 --- a/cloudinit/net/cmdline.py +++ b/cloudinit/net/cmdline.py @@ -199,7 +199,7 @@ def read_kernel_cmdline_config(files=None, mac_addrs=None, cmdline=None): if data64: return util.load_yaml(_b64dgz(data64))

ubuntu-server-builder commented 1 year ago

Launchpad user Scott Moser(smoser) wrote on 2016-11-09T02:07:37.283981+00:00

Working branch at https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/310390

Still needs another test case or two. (would like both ip6 and ip4 at once and also only ip=)

ubuntu-server-builder commented 1 year ago

Launchpad user Launchpad Janitor(janitor) wrote on 2016-11-28T22:27:29.838044+00:00

This bug was fixed in the package cloud-init - 0.7.8-61-g2d2ec70-0ubuntu1

cloud-init (0.7.8-61-g2d2ec70-0ubuntu1) zesty; urgency=medium

ubuntu-server-builder commented 1 year ago

Launchpad user Robie Basak(racb) wrote on 2016-12-09T13:51:27.430864+00:00

This is tangled up into the MAAS IPv6 SRU happening in bug 1621507. Please check that bug for verification-done before accepting cloud-init into -updates.

ubuntu-server-builder commented 1 year ago

Launchpad user Robie Basak(racb) wrote on 2016-12-09T18:20:46.962374+00:00

Hello Scott, or anyone else affected,

Accepted cloud-init into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.7.8-49-g9e904bb-0ubuntu1~16.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

ubuntu-server-builder commented 1 year ago

Launchpad user Scott Moser(smoser) wrote on 2016-12-16T15:52:14.222252+00:00

The test cases described in bug 1621507 cover the code path that this change was done to fix. Additionally, unit tests (which run during build) were added to verify the failing code path.

Specifically, this bug would be seen when the system was booted with both ip= and ip6= on the kernel command line. [+]/[+] MAAS booting IPv4 on dual-stack network (with and without dhcp6) [+]/[+] MAAS booting IPv6 on dual-stack network (with and without dhcp4)

As a result of the tests mentioned above having been done, I am marking this bug as verification-done.

ubuntu-server-builder commented 1 year ago

Launchpad user Scott Moser(smoser) wrote on 2016-12-16T17:02:59.608923+00:00

Well, further investigation showed to me that maas boots with: ip=off ip6=dhcp ip=dhcp ip6=off but will never boot with either a.) ip=dhcp ip6=dhcp b.) ip6=dhcp

An oddity in the initramfs implementation is that 'ip6=dhcp' will enable ip=dhcp. Which seems arcane, but since ip=off is available, it does at least allow the user to imply sane behavior.

Because maas will never do both ipv6 and ipv4, then in their code path the initramfs will never creates a /run/net-eth0.conf and /run/net6-eth0.conf in their environment. That was the case that the changes here fixed. So, my statement in comment 6 was incorrect.

However, I have verified that this actually does work via some manual testing using qemu and some work i'd done for open-isci testing.

We boot a qemu system like this: qemu-system-x86_64 -enable-kvm -device virtio-scsi-pci,id=virtio-scsi-xkvm -device virtio-net-pci,netdev=net00 -netdev type=tap,id=net00,script=no,downscript=no,ifname=tapvm0 -echr 0x5 -m 1024 -nographic -kernel /tmp/tgt-boot-test.UT2p0T/kernel -initrd /tmp/tgt-boot-test.UT2p0T/initrd -append "nomodeset iscsi_initiator=maas-enlist iscsi_target_name=tgt-boot-test-UT2p0T iscsi_target_ip=10.5.219.1iscsi_target_port=3260 iscsi_initiator=maas-enlist ip6=dhcp ro net.ifnames=0 BOOTIF_DEFAULT=eth0 root=/dev/disk/by-path/ip-10.5.219.1:3260-iscsi-tgt-boot-test-UT2p0T-lun-1-part1 overlayroot=tmpfs console=ttyS0 ds=nocloud-net;seedfrom=http://10.5.219.1:32600/"

Launchpad attachments: verification log on xenial

ubuntu-server-builder commented 1 year ago

Launchpad user Scott Moser(smoser) wrote on 2016-12-16T17:03:36.253686+00:00

Launchpad attachments: go: the tool in the log that patched the image and copied out kernel/initrd

ubuntu-server-builder commented 1 year ago

Launchpad user Launchpad Janitor(janitor) wrote on 2016-12-19T16:27:40.892634+00:00

This bug was fixed in the package cloud-init - 0.7.8-49-g9e904bb-0ubuntu1~16.04.2

cloud-init (0.7.8-49-g9e904bb-0ubuntu1~16.04.2) xenial-proposed; urgency=medium

ubuntu-server-builder commented 1 year ago

Launchpad user Robie Basak(racb) wrote on 2016-12-19T16:27:57.370720+00:00

The verification of the Stable Release Update for cloud-init has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

ubuntu-server-builder commented 1 year ago

Launchpad user Scott Moser(smoser) wrote on 2016-12-23T17:35:57.372227+00:00

This is fixed in cloud-init 0.7.9.

ubuntu-server-builder commented 1 year ago

Launchpad user LaMont Jones(lamont) wrote on 2017-01-04T18:44:25.585128+00:00

No maas changes were required here, since it always specifies both ip= and ip6=

ubuntu-server-builder commented 1 year ago

Launchpad user Brian Murray(brian-murray) wrote on 2017-01-12T19:47:30.593819+00:00

Hello Scott, or anyone else affected,

Accepted cloud-init into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.7.8-68-gca3ae67-0ubuntu1~16.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

ubuntu-server-builder commented 1 year ago

Launchpad user Scott Moser(smoser) wrote on 2017-01-20T18:09:44.320714+00:00

Launchpad attachments: log showing verification on yakkety

ubuntu-server-builder commented 1 year ago

Launchpad user Launchpad Janitor(janitor) wrote on 2017-01-30T18:18:12.820305+00:00

This bug was fixed in the package cloud-init - 0.7.8-68-gca3ae67-0ubuntu1~16.10.1

cloud-init (0.7.8-68-gca3ae67-0ubuntu1~16.10.1) yakkety; urgency=medium