canonical / cloud-init

Official upstream for the cloud-init: cloud instance initialization
https://cloud-init.io/
Other
2.74k stars 831 forks source link

Ntp schema definition permits empty ntp cloud-config, but code disallows #3035

Closed ubuntu-server-builder closed 1 year ago

ubuntu-server-builder commented 1 year ago

This bug was originally filed in Launchpad as LP: #1724951

Launchpad details
affected_projects = ['cloud-init (Ubuntu)', 'cloud-init (Ubuntu Xenial)', 'cloud-init (Ubuntu Zesty)', 'cloud-init (Ubuntu Artful)']
assignee = chad.smith
assignee_name = Chad Smith
date_closed = 2017-12-14T21:02:36.458848+00:00
date_created = 2017-10-19T20:09:40.303710+00:00
date_fix_committed = 2017-12-14T21:02:36.458848+00:00
date_fix_released = 2017-12-14T21:02:36.458848+00:00
id = 1724951
importance = medium
is_complete = True
lp_url = https://bugs.launchpad.net/cloud-init/+bug/1724951
milestone = None
owner = chad.smith
owner_name = Chad Smith
private = False
status = fix_released
submitter = chad.smith
submitter_name = Chad Smith
tags = ['verification-done', 'verification-done-artful', 'verification-done-xenial', 'verification-done-zesty']
duplicates = []

Launchpad user Chad Smith(chad.smith) wrote on 2017-10-19T20:09:40.303710+00:00

http://pad.lv/1724951 https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1724951

=== Begin SRU Template === [Impact] Customers who provide the following cloud-config will get a Runtime error

cloud-config

ntp:

The expected behavior, per docs, is that an empty ntp configuration will result in "4 pools will be used in the format {0-3}.{distro}.pool.ntp.org.".

[Test Case]

if [ ! -f './lxc-proposed-snapshot' ]; then   wget https://raw.githubusercontent.com/cloud-init/ubuntu-sru/master/bin/lxc-proposed-snapshot;   chmod 755 lxc-proposed-snapshot; fi

1. Provide a empty ntp configuration to cloud-init

cat > install-ntp.conf <<EOF

cloud-config

ntp: EOF

2.

for release in xenial zesty artful; do         ref=$release-proposed;         echo "$release START --------------";         lxc-proposed-snapshot --proposed --publish $release $ref;         lxc init $ref test-$release;         lxc config set test-$release user.user-data - < install-ntp.conf;         lxc start test-$release;         sleep 10;         # no runtime error         lxc exec test-$release -- cat /run/cloud-init/result.json         # ntp installed         lxc exec test-$release -- dpkg-query --show ntp;         # default pools         lxc exec test-$release -- grep pool /etc/ntp.conf done

[Regression Potential] Minimal, this fixes only a corner case where cloud-config ntp specified is completely empty. Any more complex ntp configuration are unaffected by code changes.

[Other Info] Upstream commit at   https://git.launchpad.net/cloud-init/commit/?id=6bc504e41666

=== End SRU Template ===

ubuntu-server-builder commented 1 year ago

Launchpad user Chris Halse Rogers(raof) wrote on 2017-10-25T00:14:35.390267+00:00

An upload of cloud-init to xenial-proposed has been rejected from the upload queue for the following reason: "Please re-upload including the changelog entries from the unreleased version in -proposed in the .changes file. Thanks!".

ubuntu-server-builder commented 1 year ago

Launchpad user Chris Halse Rogers(raof) wrote on 2017-10-25T00:30:16.848624+00:00

An upload of cloud-init to zesty-proposed has been rejected from the upload queue for the following reason: "Please re-upload including the changelog entries from the unreleased version in -proposed in the .changes file. Thanks!".

ubuntu-server-builder commented 1 year ago

Launchpad user Chris Halse Rogers(raof) wrote on 2017-10-25T00:34:03.270010+00:00

Hello Chad, or anyone else affected,

Accepted cloud-init into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/17.1-25-g17a15f9e-0ubuntu1~17.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

ubuntu-server-builder commented 1 year ago

Launchpad user Chris Halse Rogers(raof) wrote on 2017-10-25T03:21:12.746366+00:00

Hello Chad, or anyone else affected,

Accepted cloud-init into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/17.1-25-g17a15f9e-0ubuntu1~17.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

ubuntu-server-builder commented 1 year ago

Launchpad user Chris Halse Rogers(raof) wrote on 2017-10-25T03:29:59.133528+00:00

Hello Chad, or anyone else affected,

Accepted cloud-init into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/17.1-25-g17a15f9e-0ubuntu1~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

ubuntu-server-builder commented 1 year ago

Launchpad user Chad Smith(chad.smith) wrote on 2017-10-25T16:50:54.463134+00:00

xenial START -------------- creating xenial-proposed-226181656 [sudo] password for csmith: --proposed -- ... Get:1 http://archive.ubuntu.com/ubuntu xenial-proposed/main amd64 cloud-init all 17.1-25-g17a15f9e-0ubuntu1~16.04.1 [342 kB] ... { "v1": { "datasource": "DataSourceNoCloud [seed=/var/lib/cloud/seed/nocloud-net][dsmode=net]", "errors": [] } } ntp 1:4.2.8p4+dfsg-3ubuntu5.7

on 2011-02-08 (LP: #104525). See http://www.pool.ntp.org/join.html for

pools

pool 0.ubuntu.pool.ntp.org iburst pool 1.ubuntu.pool.ntp.org iburst pool 2.ubuntu.pool.ntp.org iburst pool 3.ubuntu.pool.ntp.org iburst

pool ntp.ubuntu.com

Needed for adding pool entries

Creating zesty-proposed-312292735 --proposed -- ... Get:1 http://archive.ubuntu.com/ubuntu zesty-proposed/main amd64 cloud-init all 17.1-25-g17a15f9e-0ubuntu1~17.04.1 [339 kB] ... { "v1": { "datasource": "DataSourceNoCloud [seed=/var/lib/cloud/seed/nocloud-net][dsmode=net]", "errors": [] } } ntp 1:4.2.8p9+dfsg-2ubuntu1.2

on 2011-02-08 (LP: #104525). See http://www.pool.ntp.org/join.html for

pools

pool 0.ubuntu.pool.ntp.org iburst pool 1.ubuntu.pool.ntp.org iburst pool 2.ubuntu.pool.ntp.org iburst pool 3.ubuntu.pool.ntp.org iburst

pool ntp.ubuntu.com

Needed for adding pool entries

artful START -------------- Creating artful-proposed-85532394 ... Get:1 http://archive.ubuntu.com/ubuntu artful-proposed/main amd64 cloud-init all 17.1-25-g17a15f9e-0ubuntu1~17.10.1 [333 kB] ... { "v1": { "datasource": "DataSourceNoCloud [seed=/var/lib/cloud/seed/nocloud-net][dsmode=net]", "errors": [] } } ntp 1:4.2.8p10+dfsg-5ubuntu3

on 2011-02-08 (LP: #104525). See http://www.pool.ntp.org/join.html for

pools

pool 0.ubuntu.pool.ntp.org iburst pool 1.ubuntu.pool.ntp.org iburst pool 2.ubuntu.pool.ntp.org iburst pool 3.ubuntu.pool.ntp.org iburst

pool ntp.ubuntu.com

Needed for adding pool entries

=== End Abridged SRU verifcation output ===

ubuntu-server-builder commented 1 year ago

Launchpad user Launchpad Janitor(janitor) wrote on 2017-10-26T08:49:10.714791+00:00

This bug was fixed in the package cloud-init - 17.1-25-g17a15f9e-0ubuntu1~17.10.1


cloud-init (17.1-25-g17a15f9e-0ubuntu1~17.10.1) artful-proposed; urgency=medium

ubuntu-server-builder commented 1 year ago

Launchpad user Launchpad Janitor(janitor) wrote on 2017-11-02T17:55:22.957773+00:00

This bug was fixed in the package cloud-init - 17.1-25-g17a15f9e-0ubuntu1~17.10.1


cloud-init (17.1-25-g17a15f9e-0ubuntu1~17.10.1) artful-proposed; urgency=medium

ubuntu-server-builder commented 1 year ago

Launchpad user Brian Murray(brian-murray) wrote on 2017-11-02T17:55:39.637992+00:00

The verification of the Stable Release Update for cloud-init has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

ubuntu-server-builder commented 1 year ago

Launchpad user Łukasz Zemczak(sil2100) wrote on 2017-11-07T17:08:05.330980+00:00

Hello Chad, or anyone else affected,

Accepted cloud-init into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/17.1-27-geb292c18-0ubuntu1~17.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

ubuntu-server-builder commented 1 year ago

Launchpad user Łukasz Zemczak(sil2100) wrote on 2017-11-07T17:18:30.240315+00:00

Hello Chad, or anyone else affected,

Accepted cloud-init into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/17.1-27-geb292c18-0ubuntu1~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

ubuntu-server-builder commented 1 year ago

Launchpad user Chad Smith(chad.smith) wrote on 2017-11-07T20:49:34.418084+00:00

=== Abridged SRU verifcation output === $ for release in xenial zesty artful; do

ref=$release-proposed; echo "$release START --------------"; lxc-proposed-snapshot -p -P $release $ref; lxc init $ref test-$release; lxc config set test-$release user.user-data - < install-ntp.conf; lxc start test-$release; sleep 10; lxc exec test-$release -- cat /run/cloud-init/result.json lxc exec test-$release -- dpkg-query --show ntp; lxc exec test-$release -- grep pool /etc/ntp.conf done xenial START -------------- Creating xenial-proposed-115658625 ... Get:1 http://archive.ubuntu.com/ubuntu xenial-proposed/main amd64 cloud-init all 17.1-27-geb292c18-0ubuntu1~16.04.1 [341 kB] Creating test-xenial

{ "v1": { "datasource": "DataSourceNoCloud [seed=/var/lib/cloud/seed/nocloud-net][dsmode=net]", "errors": [] } } ntp 1:4.2.8p4+dfsg-3ubuntu5.7

on 2011-02-08 (LP: #104525). See http://www.pool.ntp.org/join.html for

pools

pool 0.ubuntu.pool.ntp.org iburst pool 1.ubuntu.pool.ntp.org iburst pool 2.ubuntu.pool.ntp.org iburst pool 3.ubuntu.pool.ntp.org iburst

pool ntp.ubuntu.com

Needed for adding pool entries

zesty START -------------- Creating zesty-proposed-63815953 ... Get:1 http://archive.ubuntu.com/ubuntu zesty-proposed/main amd64 cloud-init all 17.1-27-geb292c18-0ubuntu1~17.04.1 [339 kB] ... Creating test-zesty { "v1": { "datasource": "DataSourceNoCloud [seed=/var/lib/cloud/seed/nocloud-net][dsmode=net]", "errors": [] } } ntp 1:4.2.8p9+dfsg-2ubuntu1.2

on 2011-02-08 (LP: #104525). See http://www.pool.ntp.org/join.html for

pools

pool 0.ubuntu.pool.ntp.org iburst pool 1.ubuntu.pool.ntp.org iburst pool 2.ubuntu.pool.ntp.org iburst pool 3.ubuntu.pool.ntp.org iburst

pool ntp.ubuntu.com

Needed for adding pool entries

artful START -------------- Creating artful-proposed-1092522261 ... Get:1 http://archive.ubuntu.com/ubuntu artful-proposed/main amd64 cloud-init all 17.1-27-geb292c18-0ubuntu1~17.10.1 [332 kB] ... Creating test-artful { "v1": { "datasource": "DataSourceNoCloud [seed=/var/lib/cloud/seed/nocloud-net][dsmode=net]", "errors": [] } } ntp 1:4.2.8p10+dfsg-5ubuntu3

on 2011-02-08 (LP: #104525). See http://www.pool.ntp.org/join.html for

pools

pool 0.ubuntu.pool.ntp.org iburst pool 1.ubuntu.pool.ntp.org iburst pool 2.ubuntu.pool.ntp.org iburst pool 3.ubuntu.pool.ntp.org iburst

pool ntp.ubuntu.com

Needed for adding pool entries

=== End Abridged SRU verifcation output ===

ubuntu-server-builder commented 1 year ago

Launchpad user Launchpad Janitor(janitor) wrote on 2017-11-14T22:23:59.287002+00:00

This bug was fixed in the package cloud-init - 17.1-27-geb292c18-0ubuntu1~17.04.1


cloud-init (17.1-27-geb292c18-0ubuntu1~17.04.1) zesty-proposed; urgency=medium

cloud-init (17.1-25-g17a15f9e-0ubuntu1~17.04.1) zesty-proposed; urgency=medium

cloud-init (17.1-18-gd4f70470-0ubuntu1~17.04.2) zesty-proposed; urgency=medium

cloud-init (17.1-18-gd4f70470-0ubuntu1~17.04.1) zesty-proposed; urgency=medium

ubuntu-server-builder commented 1 year ago

Launchpad user Launchpad Janitor(janitor) wrote on 2017-11-15T01:07:42.077466+00:00

This bug was fixed in the package cloud-init - 17.1-27-geb292c18-0ubuntu1~16.04.1


cloud-init (17.1-27-geb292c18-0ubuntu1~16.04.1) xenial-proposed; urgency=medium

cloud-init (17.1-25-g17a15f9e-0ubuntu1~16.04.1) xenial-proposed; urgency=medium

cloud-init (17.1-18-gd4f70470-0ubuntu1~16.04.2) xenial-proposed; urgency=medium

cloud-init (17.1-18-gd4f70470-0ubuntu1~16.04.1) xenial-proposed; urgency=medium

ubuntu-server-builder commented 1 year ago

Launchpad user Scott Moser(smoser) wrote on 2017-12-14T21:02:40.311209+00:00

This bug is believed to be fixed in cloud-init in 1705804. If this is still a problem for you, please make a comment and set the state back to New

Thank you.