Mypy fixes - Githubissues

canonical / cloud-init

Official upstream for the cloud-init: cloud instance initialization

https://cloud-init.io/

Other

2.89k stars 861 forks source link

Mypy fixes #5733

Closed holmanb closed 6 days ago

holmanb commented 6 days ago

Proposed Commit Message

fix: type annotations for several modules

Remove those modeles from the override list.

Test Steps

See CI coverage

Merge type

[x] Squash merge using "Proposed Commit Message"
[ ] Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#)

holmanb commented 6 days ago

I think we should be preferring List until 3.9.

Why? What we would gain by preferring the deprecated version? This is forwards compatible and cloud-init's codebase uses list and dict extensively in type annotations where not subscripted.