canonical / cloud-init

Official upstream for the cloud-init: cloud instance initialization
https://cloud-init.io/
Other
3.01k stars 887 forks source link

fix bond properties respect network schema and supported by network-manager #5768

Closed metajiji closed 1 month ago

metajiji commented 1 month ago

Proposed Commit Message

fix: bond properties respect network schema and supported by network-manager

Fixing bond properties to respect the network schema and supporting features provided by Network-Manager.

Additional Context

Not all bond options is supported before changes, for example for 802.3ad unable to pass lacp_rate option.

Also i found misspell in cloudinit/config/schemas/schema-network-config-v1.json for resend_igmp option.

Now all supported bond options by network manager has been passed, respect network schema.

Test Steps

Merge type

TheRealFalcon commented 1 month ago

@metajiji , thanks for the contribution!

I haven't fully reviewed the changes yet, but I did noticed that unit tests and ruff are failing, so those will need to be fixed before this can be accepted. Running tox locally should run through all of the checks our CI runs.

metajiji commented 1 month ago

@metajiji , thanks for the contribution!

I haven't fully reviewed the changes yet, but I did noticed that unit tests and ruff are failing, so those will need to be fixed before this can be accepted. Running tox locally should run through all of the checks our CI runs.

Sorry, my mistake, didn't run the tests locally right away, everything should be fine now! :heavy_check_mark: