Closed metajiji closed 1 month ago
@metajiji , thanks for the contribution!
I haven't fully reviewed the changes yet, but I did noticed that unit tests and ruff are failing, so those will need to be fixed before this can be accepted. Running tox
locally should run through all of the checks our CI runs.
@metajiji , thanks for the contribution!
I haven't fully reviewed the changes yet, but I did noticed that unit tests and ruff are failing, so those will need to be fixed before this can be accepted. Running
tox
locally should run through all of the checks our CI runs.
Sorry, my mistake, didn't run the tests locally right away, everything should be fine now! :heavy_check_mark:
Proposed Commit Message
Additional Context
Not all bond options is supported before changes, for example for
802.3ad
unable to passlacp_rate
option.Also i found misspell in
cloudinit/config/schemas/schema-network-config-v1.json
forresend_igmp
option.Now all supported bond options by network manager has been passed, respect network schema.
Test Steps
Merge type