Closed hcartiaux closed 1 month ago
Note: this PR may be obsoleted by #5770
@hcartiaux thank you much for your contribution to cloud-init here. I was surprised to discover this same bug while I was improving unittest coverage in my initial pass at limiting deprecated logs inside the log_ppid function. Given that the log_ppid function is removed per #5770. This is no longer an issue. Again, thank you for noticing and proposing a fix.
This fixes a bug introduced in the function
log_ppid
by the commit 75add5c72aa575d373825deddcb685f725e290d8 which renders cloud-init unusable on all non-linux systems.With this commit, cloud-init tried to log the ppid even if it was undefined, because ppid is only collected on linux distros. Here is the output of cloud-init 24.3 on OpenBSD:
This PR is an attempt to fix this issue by restoring the previous behavior of log_ppid from the commits dc7c48b9b3fbeb8548d796ae8f0e2b15246eb903 and 4abdd5a7066c322163579d8d91a44426ac705172
Proposed Commit Message
Merge type