canonical / cloud-init

Official upstream for the cloud-init: cloud instance initialization
https://cloud-init.io/
Other
3.01k stars 887 forks source link

Enable the sysv init scripts in OpenBSD build script #5790

Closed hcartiaux closed 1 month ago

hcartiaux commented 1 month ago

Proposed Commit Message

<type>fix(openbsd)</type>: Enable sysv init scripts in OpenBSD build script

This replaces the use of `/etc/rc.local` in the OpenBSD build script by the sysv init scripts provided with cloud-init.

Fixes GH-4036
LP: #1992853

Additional Context

I've fixed a bug in the sysv init scripts by disabling rc_bg="YES", otherwise it would fail to execute correctly with this error at boot:

rcctl start cloudconfig 
cloudconfig/etc/rc.d/cloudconfig: kill: 66598: No such process
(ok)

Also, /etc/rc.local is not needed anymore, /var/run is managed by the system and does not have to be cleaned up manually.

Test Steps

My own CI: https://github.com/hcartiaux/openbsd-cloud-image/actions/

I've also tested manually to have a closer look at the output.

Merge type

holmanb commented 1 month ago

@igalic could you take a look at this please?

hcartiaux commented 1 month ago

@holmanb I fear @igalic is not available at the moment, she's not active on github for quite a few weeks with the status "dnd". Anybody else could review? Thanks.