search

canonical / cluster-api-bootstrap-provider-microk8s

This project offers a cluster API bootstrap provider controller that manages the node provision of a MicroK8s cluster.
https://microk8s.io
21 stars 14 forks source link

add new SnapstoreProxyScheme field #111

Closed eaudetcobello closed 1 month ago

eaudetcobello commented 1 month ago

Adds a new SnapStoreProxyScheme field to the Microk8sConfig type.

This field is meant to be either http or https without ://. For backwards-compatibility reasons this new field has been added because the existing field was called SnapstoreProxyDomain and I do not think it's appropriate for a variable with that name to specify the URL scheme.

This addresses https://github.com/canonical/cluster-api-bootstrap-provider-microk8s/issues/108

ktsakalozos commented 1 month ago

We should not be changing the current behavior. We must not break existing setups. Therefore the default value of the "SnapstoreProxyScheme" should be "http" if not set.