search

canonical / cluster-api-control-plane-provider-microk8s

This project offers a cluster API control plane controller that manages the control plane of a MicroK8s cluster. It is expected to be used along with the respective MicroK8s specific machine bootstrap provider.
https://microk8s.io
7 stars 5 forks source link

Add golangci-lint #21

Closed neoaggelos closed 1 year ago

neoaggelos commented 1 year ago

Merge after #20

neoaggelos commented 1 year ago

This is hardcoded in a few other parts, so it would not be use in this Makefile. I see the value of this, though

On Tue, Oct 25, 2022, 2:32 PM Sachin Kumar Singh @.***> wrote:

@.**** commented on this pull request.

In Makefile https://github.com/canonical/cluster-api-control-plane-provider-microk8s/pull/21#discussion_r1004371015 :

@@ -95,6 +94,10 @@ docker-manifest: docker-push ## Push docker multi-arch manifest. docker manifest annotate ${IMG} ${IMG}-arm64 --arch=arm64 docker manifest push ${IMG}

+.PHONY: lint +lint: golangci-lint ## Lint the codebase

  • $(GOLANGCI_LINT) run -v --go=1.19 --timeout 3m0s

Can we use the golang version as a variable? Something like GOLANG_VERSION=1.19?

— Reply to this email directly, view it on GitHub https://github.com/canonical/cluster-api-control-plane-provider-microk8s/pull/21#pullrequestreview-1154640762, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAONDCTOTZAHEQB56UMFSNTWE7AMZANCNFSM6AAAAAARN2SVNM . You are receiving this because you authored the thread.Message ID: <canonical/cluster-api-control-plane-provider-microk8s/pull/21/review/1154640762 @github.com>