search

canonical / colcon-in-container

Colcon extension to build a colcon workspace in a container
GNU General Public License v3.0
26 stars 1 forks source link

`release-in-container` appears to assume `package_name` == pkg directory #29

Open gavanderhoorn opened 1 month ago

gavanderhoorn commented 1 month ago

As per title.

Looking at _bloom_generate(..) fi:

https://github.com/canonical/colcon-in-container/blob/39379e11fd91c7d46fc3a8c37c047d5f6a56682f/colcon_in_container/verb/release_in_container.py#L88-L92

in case package a is actually in dir b (on disk), this fails for me (as cd /ws/src/a will not work).

Technically there is no requirement for a ROS package to be hosted in a directory with the same name as the one listed in the manifest. It's often the case though, but would be nice to not assume it.