search

canonical / colcon-in-container

Colcon extension to build a colcon workspace in a container
GNU General Public License v3.0
26 stars 1 forks source link

Interest in Docker support? #30

Open gavanderhoorn opened 2 weeks ago

gavanderhoorn commented 2 weeks ago

First: thank you for making this package available.

As I had a need to build packages in Docker containers I spent some time adding support for that. I've pushed those changes to my fork: https://github.com/canonical/colcon-in-container/compare/main...gavanderhoorn:colcon-in-container:docker_provider.

At this point I believe it has feature parity with the LXD and Multipass providers, in addition to a Docker-specific approach for #23 (allow builds to be based on a user-provided Docker image, which could contain more than just the base development/build environment).

It has worked well enough for me, so I thought I'd let you know about it.

artivis commented 2 weeks ago

Hi @gavanderhoorn, This sounds like a great addition!

However I'm not sure we want to support custom user-provided images (BYOI). This open the door to tickets being filed for issues outside of our control.

Anyhow, why don't you open a PR so that we look and discuss at it?