Remove build-time openssh-server host keys and add service to auto-generating them on boot.

canonical / core18

The core18 base snap

14 stars 26 forks source link

Remove build-time openssh-server host keys and add service to auto-generating them on boot. #108

Closed sil2100 closed 5 years ago

sil2100 commented 5 years ago

This is apparently another thing that we missed because of not looking at livecd-rootfs code and the core-builder parts. Currently we seem to ship ssh host keys which, as I understand it (and see it) causes each image have the same ssh key fingerprint (!).

This is all pulled in from live-build's remove-openssh-server-host-keys hook and the files in core-build repository.

sil2100 commented 5 years ago

Tested this and it seems to work properly now. Previously every new image built had the same SSH host key everytime. Now each one has a new, 'unique' ssh host key generated on boot as expected.

sil2100 commented 5 years ago

mvo said it looks ok so I'll just 'do it' and merge.