canonical / core18

The core18 base snap
14 stars 26 forks source link

run-snapd-from-snap: check for snapd.service existing too #140

Closed anonymouse64 closed 5 years ago

anonymouse64 commented 5 years ago

If state.json exists, but snapd.service doesn't, then we were likely interrupted before the snapd-seeding from /tmp was able to bootstrap the full snapd from the snap, so we still need to do that now.

Fixes: https://bugs.launchpad.net/snapd/+bug/1845310

See the LP bug for more details. Currently unclear how to test this change here unfortunately, but we are working on doing nested kvm spread tests in snapd that test this. Perhaps we should have nested kvm tests here too?

anonymouse64 commented 5 years ago

There's some additional information on how to test this available here: https://github.com/anonymouse64/uc18-lp-1845310

Unfortunately for this bug (but perhaps fortunately for me) I will be off for the next few days, so someone else is free to take up this PR and get it merged/released as necessary.