canonical / core18

The core18 base snap
14 stars 26 forks source link

Make .disk/info visible on the root partition #152

Closed sil2100 closed 4 years ago

sil2100 commented 4 years ago

Ok, bare with me here for a minute, this is just one possibility - I know this basically sucks and is not the cleanest solution of all. Basically the problem here is: we have a .disk/info file in /writable/.disk/info with the image build info that we'd like to export in the root directory since we already have far too many places where users have to look for this file. There's a few ways we can do this, two of them are:

1) Create a permanent symlink on the root partition to /writable/.disk/. The plus-side of it is that it's simple and non-invasive. The down-side of it is that if /writable/.disk/ does not exist, we basically have a dangling broken symlink in /. I don't think this is too big of a problem as this file is hidden by default anyway.

2) Bind-mount /writable/.disk to /.disk. We could do that via fstab (though we wanted to have it empty on the base system) or by having a service do that dynamically on startup. The latter is nice because we could bind-mount it only if /writable/.disk/ exists, so no more dangling symlinks or other ugliness. The problem though is that this requires hackery for such a small thing like a /.disk/info file.

I went here with choice 1, but we could go for 2 as well. We could also screw it and just point people to /writable/.disk/info, but I heard some people complaining about it.

xnox commented 4 years ago

/var/log/installer/media-info

sil2100 commented 4 years ago

Ok, so I talked with mvo about this and he was generally +1. It's not such a big of a deal to waste time over exquisite solutions - this will do, for now.