search

canonical / core18

The core18 base snap
14 stars 26 forks source link

Add motd and issue to writable /etc files #156

Closed WillNilges closed 4 years ago

WillNilges commented 4 years ago

As an embedded developer, I'd like to be able to modify my motd and issue banners with a config hook when installing my Ubuntu Core image. Because these files are unwritable currently, It appears I straight-up cannot do that, so, I'd like to add them to the writable directory so that they can be modified.

WillNilges commented 4 years ago

If this does get ACK'd, would you mind filing another PR against core20 and core? Thanks

Sure thing :+1:

WillNilges commented 4 years ago

@mvo5 @xnox Would you guys mind having a look at this sometime this week? I need this feature for a deadline coming up pretty soon.

anonymouse64 commented 4 years ago

@WillNilges can you also adjust the corresponding tests in https://github.com/snapcore/core18/blob/master/hook-tests/008-etc-writable.test

anonymouse64 commented 4 years ago

Also perhaps @sil2100 could take a look

WillNilges commented 4 years ago

As an aside, I've messed around with this feature in my branch quite a bit and it does exactly what you'd expect it to: Make issue and motd writable.

snowsky commented 3 years ago

Can you please port this PR to core20 and future versions? Thanks.