canonical / core18

The core18 base snap
14 stars 26 forks source link

hooks: ensure /etc/login.defs PATHs contain /snap/bin #39

Closed mvo5 closed 6 years ago

mvo5 commented 6 years ago

In ubuntu 18.04 /etc/environment is no longer used for the PATH when using "su". It is unclear if this is a desired change but until the root cause is found this PR adds /snap/bin to the PATH in /etc/login.defs which is read by "su".

This will also unbreak some snapd integration tests that use 'su -l -c "cmd" test'.

mvo5 commented 6 years ago

I tested this locally now and this should unblock some snapd tests on core18.

mvo5 commented 6 years ago

@bboozzoo Yeah, I am looking into this currently, the why is still unclear :/

mvo5 commented 6 years ago

Just for the record: https://github.com/shadow-maint/shadow/pull/119 is the upstream fix.