search

canonical / cos-configuration-k8s-operator

This charmed operator for Kubernetes enables you to provide configurations to various components of the Canonical Observability Stack (COS) bundle.
https://charmhub.io/cos-configuration-k8s
Apache License 2.0
4 stars 6 forks source link

update libraries #34

Closed lucabello closed 1 year ago

simskij commented 1 year ago

@lucabello seems like the integration tests might need some updating to accommodate for the changes in the lib.

rbarry82 commented 1 year ago

@lucabello seems like the integration tests might need some updating to accommodate for the changes in the lib.

I don't think this is changes in the lib. The integration test looks here. And there are two dashboards:

Traceback (most recent call last):
  File "/home/runner/work/cos-configuration-k8s-operator/cos-configuration-k8s-operator/tests/integration/test_grafana_dashboards.py", line 86, in test_dashboard_files_ingested_by_grafana
    assert "up with dropdowns" in dashboard_titles
AssertionError: assert 'up with dropdowns' in ['up (with datasource variables)', 'up (without datasource variables)']

Those match up to the titles in the dashboards it passes. There just doesn't seem to be a dashboard titled up with dropdowns in the repo at all. I don't see a commit where it would have been dropped, either.

@sed-i am I missing something?

lucabello commented 1 year ago

It's an integration test that has not been updated; you can see the dashboard the test is trying to find here. It also means this is probably not the first time this test should have failed (and in fact the last merge has failing CI). In any case, I'm updating the dashboard names to the ones we currently have!