search

canonical / cos-configuration-k8s-operator

https://charmhub.io/cos-configuration-k8s
Apache License 2.0
4 stars 6 forks source link

Tell LokiPushApiConsumer not to add topology labels to alerts #56

Closed rbarry82 closed 1 year ago

rbarry82 commented 1 year ago

Issue

Use the new arg in LokiPushApiConsumer to bypass topology label injection. Closes #44

Release Notes

Use the new arg in LokiPushApiConsumer to bypass topology label injection.

rbarry82 commented 1 year ago

I agree in principle, but it's hard to see a use case for this which isn't cos-config, and while there's a wild west of dashboards (which may want cluster-level overviews where topology is counterproductive or meaningless), having this exposed as a constructor arg benefits from users explicitly "opting in" to the negative case.