search

canonical / cos-configuration-k8s-operator

This charmed operator for Kubernetes enables you to provide configurations to various components of the Canonical Observability Stack (COS) bundle.
https://charmhub.io/cos-configuration-k8s
Apache License 2.0
4 stars 5 forks source link

honor juju proxy settings when running git-sync #76

Closed lucabello closed 8 months ago

lucabello commented 8 months ago

Issue

Closes #71.

Solution

The charm should honor the Juju proxy settings when executing git-sync.

Juju lets you set some proxy configuration which ends up in the environment variables named JUJU_CHARM_HTTP_PROXY, JUJU_CHARM_HTTPS_PROXY, and JUJU_CHARM_NO_PROXY.

However, the charms don't automatically honor this configuration; instead, they require to set some other environment variables for the proxy configuration to take effect, namely http_proxy, https_proxy, and no_proxy. It's up to each individual charm to honor the Juju proxy settings or not.

This PR makes the change for the git-sync command :)

lucabello commented 8 months ago

I elaborated more in the PR description!