search

canonical / cpc-sbom

CPC maintained tool for generating SBOM for cloud images
GNU General Public License v3.0
7 stars 0 forks source link

ci: fix snap asset file name #43

Closed ahresse closed 11 months ago

ahresse commented 11 months ago

The uploaded snap package asset isn't actually a zip file.

For example:

$ unzip -t cpc-sbom-v0.1.15.snap.zip 
Archive:  cpc-sbom-v0.1.15.snap.zip
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of cpc-sbom-v0.1.15.snap.zip or
        cpc-sbom-v0.1.15.snap.zip.zip, and cannot find cpc-sbom-v0.1.15.snap.zip.ZIP, period.

I wasn't able to test this on my repo (The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings.)

Thus, I propose to set the appropriate name and MIME type on the GitHub worflow.

Not sure about the appropriate MIME type but Freedesktop uses application/vnd.snap (https://cgit.freedesktop.org/xdg/shared-mime-info/commit/?id=4882ca0ca00bba68d8d8ddaf43dc486634c35043)

philroche commented 11 months ago

Thank you