search

canonical / craft-actions

1 stars 6 forks source link

feat: add input to pin lxd channel #29

Closed hemanthnakkina closed 1 month ago

hemanthnakkina commented 1 month ago

This PR adds new parameter lxd-channel to the rockcraft action. The parameter defaults to '5.21/stable' to maintain the backward compatiblity.

tigarmo commented 1 month ago

Hi @hemanthnakkina , thanks for the PR. Discussing this internally today we believe that a better approach would be to not touch the LXD installation at all, only installing it if there's no LXD snap installed. This would be more flexible as it would cover more needs - for instance, if a user needs to use a specific revision instead of a channel they can.

hemanthnakkina commented 1 month ago

@tigarmo Thanks for the review. I have raised https://github.com/canonical/craft-actions/pull/30 as per your suggestion. Closing this PR.