canonical / craft-actions

1 stars 6 forks source link

[feature request] add support for packing rocks in multiple dirs #8

Closed DnPlas closed 1 year ago

DnPlas commented 1 year ago

At the moment, the action automatically packs rocks in the root of the repository where the action is called or from path, assuming the Rockcraft project is there, but there are repositories, for instance pipelines-rocks, where the root of the repository does not contain a Rockcraft project, and there are instead, multiple of them inside different directories.

cjdcordeiro commented 1 year ago

hi @DnPlas ! That sounds like a valid use case. I wonder however if it wouldn't be better to use a matrix in the GH workflow? You can have the different folders be inputs to the matrix. That would be much more efficient as all builds would happen in parallel (which would be much harder to do while guaranteeing performance, if we do it from within this action)

DnPlas commented 1 year ago

Yeah, that's fair and works.