canonical / craft-application

The basis for *craft applications
https://canonical-craft-application.readthedocs-hosted.com/en/latest
GNU Lesser General Public License v3.0
7 stars 11 forks source link

fix(models): address adopt-info validation by name #227

Closed cmatsuoka closed 7 months ago

cmatsuoka commented 7 months ago

Pydantic 1.x seemingly root-validates using both file alias and name, leading to inconsistent behavior. This should address the issue for now, but the issue warrants further investigation.

Signed-off-by: Claudio Matsuoka claudio.matsuoka@canonical.com


codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0705676) 99.28% compared to head (bea7ae2) 89.14%. Report is 34 commits behind head on main.

:exclamation: Current head bea7ae2 differs from pull request most recent head f60d534. Consider uploading reports for the commit f60d534 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #227 +/- ## =========================================== - Coverage 99.28% 89.14% -10.15% =========================================== Files 29 46 +17 Lines 1265 2358 +1093 Branches 209 410 +201 =========================================== + Hits 1256 2102 +846 - Misses 6 213 +207 - Partials 3 43 +40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sergiusens commented 7 months ago

would be nice to see a unit test

cmatsuoka commented 7 months ago

would be nice to see a unit test

Unit test added!