feat(provider)!: get build env from command line, env, and snap config

mr-cal commented 4 months ago

[x] Have you followed the guidelines for contributing?
[x] Have you signed the CLA?
[x] Have you successfully run tox?

Extend get_provider() to get the provider from the command line (--use-lxd), the environment (CRAFT_BUILD_ENVIRONMENT) or the snap config
Extend run_managed() to see if CRAFT_BUILD_ENVIRONMENT=host

I decided not to add spread tests in snapcraft because they are time-consuming and hard to verify (whether LXD or Multipass was used, the artifact will be the same in the end).

(CRAFT-2477)

mr-cal commented 4 months ago

The snapcraft spread tests for this PR look as-expected: https://github.com/canonical/snapcraft/pull/4616

mr-cal commented 3 months ago

I'm happy with the spread tests in https://github.com/canonical/snapcraft/pull/4616, so this is ready for re-review

mr-cal commented 3 months ago

If any application runs into errors after this commit, see the required changes here: https://github.com/canonical/snapcraft/pull/4616/files#diff-0ad07cc1348fa5702cc5592f8b44f3ca055ec65683cf27738038002e75ecf8d0R54

canonical / craft-application

feat(provider)!: get build env from command line, env, and snap config #242